Fix pyinfo for Python 3.12 changes #15103
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
hauntsaninja
commented
Apr 23, 2023
| @@ -22,6 +19,10 @@ | |||
|
|
|||
| sys.path = old_sys_path | |||
|
|
|||
| import os | |||
| import site | |||
| import sysconfig | |||
There was a problem hiding this comment.
sysconfig now imports types, so we need to do the path hack sooner
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
emmatyping
reviewed
Apr 24, 2023
| from distutils.sysconfig import get_python_lib | ||
|
|
||
| res = [get_python_lib()] | ||
| res = [sysconfig.get_paths()["purelib"]] |
There was a problem hiding this comment.
Something I don't recall, are purelib and sitepackages 1-to-1? I also don't recall if platdir is included in getsitepackages.
There was a problem hiding this comment.
Ah yeah, I think what I have is equivalent to get_python_lib, but I think you're right that platlibdir is in getsitepackages
|
I'm going to merge this so it doesn't conflict with a good-first-issue that we'll do at the sprints, but I'll look into whether we should add platlibdir to this branch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.